Normalize google-discovery plugin secret/connection refs#521
Draft
RhysSullivan wants to merge 1 commit intors/normalize-mcpfrom
Draft
Normalize google-discovery plugin secret/connection refs#521RhysSullivan wants to merge 1 commit intors/normalize-mcpfrom
RhysSullivan wants to merge 1 commit intors/normalize-mcpfrom
Conversation
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 4, 2026
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 41b0ace | May 04 2026, 07:54 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 41b0ace | Commit Preview URL Branch Preview URL |
May 04 2026, 07:52 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/storage-core
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Move secret/connection references out of the JSON google_discovery_source.config column into: - Flat columns on google_discovery_source: auth_kind, auth_connection_id, auth_client_id_secret_id, auth_client_secret_secret_id, auth_scopes (each indexed where it carries a ref). Replaces the GoogleDiscoveryAuth json. - google_discovery_source_credential_header / google_discovery_source_credential_query_param: child tables for the optional GoogleDiscoveryFetchCredentials SecretBackedMap entries. The remaining structural fields (discoveryUrl, service, version, rootUrl, servicePath) stay in `config` as JSON — they're plugin-private and never carry refs. google_discovery_binding stays JSON too: the GoogleDiscoveryMethodBinding has no refs, and method input/output schemas are arbitrary user data. Plugin gains usagesForSecret / usagesForConnection. Migration 0010 backfills via json_extract / json_each, then strips the extracted fields with json_remove. Three migration tests cover backfill from a hand-seeded pre-migration DB; one plugin-level test covers usage fan-out across auth_*_secret_id and auth_connection_id.
RhysSullivan
force-pushed
the
rs/normalize-mcp
branch
from
eca66cf to
45caef2
Compare
RhysSullivan
force-pushed
the
rs/normalize-google-discovery
branch
from
f2d49d3 to
41b0ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move secret/connection references out of the JSON
google_discovery_source.config column into:
auth_connection_id, auth_client_id_secret_id,
auth_client_secret_secret_id, auth_scopes (each indexed where it
carries a ref). Replaces the GoogleDiscoveryAuth json.
google_discovery_source_credential_query_param: child tables for the
optional GoogleDiscoveryFetchCredentials SecretBackedMap entries.
The remaining structural fields (discoveryUrl, service, version,
rootUrl, servicePath) stay in
configas JSON — they're plugin-privateand never carry refs. google_discovery_binding stays JSON too: the
GoogleDiscoveryMethodBinding has no refs, and method input/output
schemas are arbitrary user data.
Plugin gains usagesForSecret / usagesForConnection. Migration 0010
backfills via json_extract / json_each, then strips the extracted
fields with json_remove. Three migration tests cover backfill from a
hand-seeded pre-migration DB; one plugin-level test covers usage
fan-out across auth_*_secret_id and auth_connection_id.